Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make url input always controlled on share post bar #2200

Merged
merged 6 commits into from
Sep 19, 2023
Merged

fix: make url input always controlled on share post bar #2200

merged 6 commits into from
Sep 19, 2023

Conversation

DragosIorgulescu
Copy link
Contributor

Changes

  • sets the default value of the URL input to an empty string

Events

N / A

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

WT-1846 #done

@DragosIorgulescu DragosIorgulescu self-assigned this Sep 19, 2023
@DragosIorgulescu DragosIorgulescu requested a review from a team September 19, 2023 10:51
capJavert
capJavert approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@capJavert capJavert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@DragosIorgulescu DragosIorgulescu enabled auto-merge (squash) September 19, 2023 14:03
@DragosIorgulescu DragosIorgulescu merged commit e48a1b7 into WT-1778-move-to-react Sep 19, 2023
3 of 4 checks passed
@DragosIorgulescu DragosIorgulescu deleted the WT-1846-share-post-bar-uncontrolled-error branch September 19, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capJavert capJavert capJavert approved these changes

@rebelchris rebelchris Awaiting requested review from rebelchris

@sshanzel sshanzel Awaiting requested review from sshanzel

Assignees

@DragosIorgulescu DragosIorgulescu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@DragosIorgulescu @capJavert