Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move alert assertion before mutation submission #2213

Merged
merged 2 commits into from Sep 20, 2023
Merged

fix: move alert assertion before mutation submission #2213

merged 2 commits into from Sep 20, 2023

Conversation

DragosIorgulescu
Copy link
Contributor

@DragosIorgulescu DragosIorgulescu commented Sep 20, 2023 •
edited

Changes

馃 馃檹

Changes explanation:

  • the toast is triggered optimistically upon submission, so waiting for the mutation to finish executing might generate situations where the toast is already gone and the assertion would fail.

Events

N / A

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

WT-1834 #done

@DragosIorgulescu DragosIorgulescu requested a review from a team as a code owner September 20, 2023 13:16
@DragosIorgulescu DragosIorgulescu self-assigned this Sep 20, 2023
@DragosIorgulescu DragosIorgulescu enabled auto-merge (squash) September 20, 2023 13:29
@DragosIorgulescu DragosIorgulescu merged commit 8be15a5 into WT-1778-move-to-react Sep 20, 2023
1 of 3 checks passed
@DragosIorgulescu DragosIorgulescu deleted the WT-1834-fix-feeding-toast branch September 20, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelchris rebelchris rebelchris approved these changes

Assignees

@DragosIorgulescu DragosIorgulescu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@DragosIorgulescu @rebelchris