Support Linear ads events and Player Operation events for VAST 4.1 #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ST 4.1 moved mocha configs to separate file to be able run any isolated test from IDE
kobawan
reviewed
Jul 12, 2019
src/vast_tracker.js
Outdated
| * or to the extent that it is ready to play the media | ||
| * Calls the load tracking URLs. | ||
| * | ||
| * @emits VASTTracker#complete |
There was a problem hiding this comment.
shouldn't it emit 'loaded"?
| @@ -278,6 +278,7 @@ export class VASTTracker extends EventEmitter { | |||
| setExpand(expanded) { | |||
| if (this.expanded !== expanded) { | |||
| this.track(expanded ? 'expand' : 'collapse'); | |||
| this.track(expanded ? 'playerExpand' : 'playerCollapse'); | |||
There was a problem hiding this comment.
please add jsdocs for these trackers as well :)
eliamaino-fp
approved these changes
Jul 19, 2019
kobawan
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Linear ads events and Player Operation events for VAST 4.1
moved mocha configs to separate file to be able run any isolated test from IDE
Description
VAST 4.1 contains additional tracking events: playerExpand/playerCollapse which eventually replaces the fullscreen/exitFullscreen events and loaded which track then everything loaded for playing.
Type