[client] Send warning event on missing required fields #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobawan
reviewed
Sep 12, 2019
kobawan
suggested changes
Sep 16, 2019
kobawan
reviewed
Sep 16, 2019
kobawan
reviewed
Sep 17, 2019
rumesh
reviewed
Sep 18, 2019
| * @return {Ad} | ||
| */ | ||
| export function parseAd(adElement) { | ||
| export function parseAd(adElement, emit) { |
There was a problem hiding this comment.
Because of the new parameter this PR should be flagged as Breaking change as it changes api
…est for vast verification
kobawan
reviewed
Sep 19, 2019
kobawan
reviewed
Sep 20, 2019
Closed
src/parser/parser_verification.js
Outdated
| { name, parentName, attributes, subElements, oneOfResources }, | ||
| emit | ||
| ) { | ||
| let message = `Element `; |
There was a problem hiding this comment.
Might be better to put the name here already and use else if, and else for the last statement, if we can only have one kind of error per message.
clementFrancon
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trigger a "VAST-warning" if any required attributes or subelements are missing in any element.
According to https://iabtechlab.com/wp-content/uploads/2018/11/VAST4.1-final-Nov-8-2018.pdf
Type