Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix3.0/issue 319 #329

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Fix3.0/issue 319 #329

merged 2 commits into from
Oct 7, 2019

Conversation

rgulrajani
Copy link
Contributor

Description

Changes to add missing attributes to the Companion and Icon elements as per VAST 4.1 spec

Issue

#319

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

@kobawan kobawan added this to the 3.0 milestone Oct 7, 2019
@kobawan kobawan added 3.0 3.0 roadmap enhancement feature hacktoberfest Participate in 2019's hacktoberfest! labels Oct 7, 2019
kobawan
kobawan approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@kobawan kobawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rumesh
rumesh approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@rumesh rumesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kobawan kobawan merged commit 43c83e1 into dailymotion:3.0-version Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumesh rumesh rumesh approved these changes

@kobawan kobawan kobawan approved these changes

Assignees
No one assigned
Labels
3.0 3.0 roadmap enhancement feature hacktoberfest Participate in 2019's hacktoberfest!
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgulrajani @rumesh @kobawan