Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix3.0/issue 320 #335

Merged
merged 4 commits into from
Oct 17, 2019
Merged

Fix3.0/issue 320 #335

merged 4 commits into from
Oct 17, 2019

Conversation

rgulrajani
Copy link
Contributor

Description

Implement missing attributes and sub elements for MediaFile

Issue

#320

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

@kobawan kobawan added 3.0 3.0 roadmap enhancement feature hacktoberfest Participate in 2019's hacktoberfest! labels Oct 15, 2019
@kobawan kobawan added this to the 3.0 milestone Oct 15, 2019
kobawan
kobawan reviewed Oct 16, 2019
View reviewed changes
Copy link
Contributor

@kobawan kobawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work! Just a few minor things to improve :)

docs/api/class-reference.md Outdated Show resolved Hide resolved
docs/api/class-reference.md Show resolved Hide resolved
src/interactive_creative_file.js Show resolved Hide resolved
src/parser/creative_linear_parser.js Outdated Show resolved Hide resolved
kobawan
kobawan reviewed Oct 16, 2019
View reviewed changes
src/interactive_creative_file.js Outdated Show resolved Hide resolved
src/interactive_creative_file.js Show resolved Hide resolved
src/closed_caption_file.js Outdated Show resolved Hide resolved
src/parser/creative_linear_parser.js Outdated Show resolved Hide resolved
src/parser/creative_linear_parser.js Outdated Show resolved Hide resolved
kobawan
kobawan approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@kobawan kobawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait for another approval :)

ZacharieTFR
ZacharieTFR approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@ZacharieTFR ZacharieTFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 👍

@kobawan kobawan merged commit 11c32b1 into dailymotion:3.0-version Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobawan kobawan kobawan approved these changes

@ZacharieTFR ZacharieTFR ZacharieTFR approved these changes

Assignees
No one assigned
Labels
3.0 3.0 roadmap enhancement feature hacktoberfest Participate in 2019's hacktoberfest! refactor
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgulrajani @kobawan @ZacharieTFR