Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node_url_handler bad import #347

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fix node_url_handler bad import #347

merged 1 commit into from
Nov 4, 2019

Conversation

kobawan
Copy link
Contributor

@kobawan kobawan commented Nov 4, 2019

Description

Vast-client built node file (from 3.0.0-alpha.7) throws error:

Error: Cannot find module './consts'
    at Function.Module._resolveFilename (module.js:548:15)
    at Function.Module._load (module.js:475:25)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/node_modules/vast-client/dist/vast-client-node.min.js:1:30219)

Because of import that is not transpiled by babel.

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

@kobawan kobawan added bug 3.0 3.0 roadmap labels Nov 4, 2019
@kobawan kobawan self-assigned this Nov 4, 2019
@kobawan kobawan mentioned this pull request Nov 4, 2019
Merged
23 tasks
@kobawan kobawan merged commit 1e7ef25 into 3.0-version Nov 4, 2019
@kobawan kobawan deleted the alpha7-fix branch November 4, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clementFrancon clementFrancon clementFrancon approved these changes

Assignees

@kobawan kobawan

Labels
3.0 3.0 roadmap bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kobawan @clementFrancon