Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 3.0-version documentation #361

Merged
merged 14 commits into from
Sep 25, 2020
Merged

Conversation

ZacharieTFR
Copy link
Contributor

@ZacharieTFR ZacharieTFR commented Jun 10, 2020

Description

This PR improve the documentation by:

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

@ZacharieTFR ZacharieTFR added documentation chore Anything not involving production features labels Jun 10, 2020
@ZacharieTFR ZacharieTFR self-assigned this Jun 10, 2020
@ZacharieTFR ZacharieTFR changed the title Fix typos in documentation Improve 3.0-version documentation Jun 26, 2020
Copy link
Contributor

@clementFrancon clementFrancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small comment otherwise LGTM ;)


The user clicked or otherwise activated a control used to minimize the ad to a size smaller than a collapsed ad but
without fully dispatching the ad from the player environment. Unlike a collapsed ad that is big enough to display it’s
message,the minimized ad is only big enough to offer a control that enables the user to redisplay the ad if desired.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space : message, the minimized

ZacharieTFR and others added 3 commits September 25, 2020 16:12
Co-authored-by: Françon Clément <clement.francon@dailymotion.com>
Co-authored-by: Françon Clément <clement.francon@dailymotion.com>
[doc] Add 3.0-version migration docs
@ZacharieTFR ZacharieTFR merged commit 1878e4e into 3.0-version Sep 25, 2020
@ZacharieTFR ZacharieTFR deleted the 3.0-documentation-update branch September 25, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Anything not involving production features documentation
Development

Successfully merging this pull request may close these issues.

None yet

3 participants