Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep wrapper sequence value when containing only one final ad #363

Merged
merged 3 commits into from
Jun 26, 2020

Conversation

ZacharieTFR
Copy link
Contributor

Description

This PR will allow to replace the sequence attribute of an Inline ad by the one of its parent wrapper. the replacement will be made only if the wrapper contains only one ad. Otherwise sequences from the unwrapped ad will be kept.

e.g,for a use case where an AdPod contain:

- Inline with sequence 1
- Inline with sequence 2
- Wrapper with sequence 3 wrapping a Inline with sequence 1

once parsed we will obtain :

- Inline sequence 1,
- Inline sequence 2,
- Inline sequence 3

In the use case where a wrapper wrap an AdPod, the wrapper sequence will be ignored.
e.g

- Wrapper sequence 3 containing:
  - Inline sequence 1,
  - Inline sequence 2,
  - Inline sequence 3

once parsed we will obtain :

- Inline sequence 1,
- Inline sequence 2,
- Inline sequence 3

Issue

#357

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

Copy link
Contributor

@clementFrancon clementFrancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ZacharieTFR ZacharieTFR requested a review from rumesh June 26, 2020 14:20
Copy link
Contributor

@rumesh rumesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rumesh rumesh merged commit 7772d0e into 3.0-version Jun 26, 2020
@rumesh rumesh deleted the wrapper-sequence branch June 26, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants