Ad data on resolving events #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacharieTFR
reviewed
Feb 11, 2022
src/parser/vast_parser.js
Outdated
| * @emits VASTParser#VAST-resolving | ||
| * @emits VASTParser#VAST-resolved | ||
| * @return {Promise} | ||
| */ | ||
| fetchVAST(url, wrapperDepth = 0, previousUrl = null) { | ||
| fetchVAST(url, wrapperDepth = 0, previousUrl = null, ad = null) { |
There was a problem hiding this comment.
What do you think about renaming ad to wrapperAd to make it more explicit (especially on the markdown documentation)
Suggested change
| fetchVAST(url, wrapperDepth = 0, previousUrl = null, ad = null) { | |
| fetchVAST(url, wrapperDepth = 0, previousUrl = null, wrapperAd = null) { |
clementFrancon
commented
Feb 11, 2022
src/parser/vast_parser.js
Outdated
| @@ -129,6 +130,7 @@ export class VASTParser extends EventEmitter { | |||
| wrapperDepth, | |||
| maxWrapperDepth: this.maxWrapperDepth, | |||
| timeout: this.fetchingOptions.timeout, | |||
| ad, | |||
There was a problem hiding this comment.
not sure if we should call it ad or parentAd or something WDYT?
There was a problem hiding this comment.
Wow 1 sec between our comments, ok I'll change it
clementFrancon
force-pushed
the
ad-data-on-resolving-events
branch
from
79285ce
to
2e6f562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to troubleshoot ad performances, we need to have some information on the current ad node being resolved
Type