Upgrade to babel 7 and update packages #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumesh
reviewed
Oct 8, 2019
src/parser_utils.js
Outdated
Comment on lines
34
to
35
| const cdatas = []; | ||
| for (const childKey in node.childNodes) { |
There was a problem hiding this comment.
Suggested change
| const cdatas = []; | |
| for (const childKey in node.childNodes) { | |
| const childNodes = node.childNodes; | |
| for (const childKey in childNodes) { |
As node.childNodes is used sevral time in the code shoud use local var, because accessing with node.childNodes could be bad in performance in a big VMAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for packages using babel 7 to be able to transpile vmap's library code, this package also needs to be updated to babel 7.
Had to fix destructuring of NodeLists, as that should not be possible, and after upgrading to babel 7 it threw errors. Since I removed destructuring, the polyfills have also been automatically removed by babel.
Bonus: updated other packages versioning.
BREAKING CHANGE!!!