Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify the logic about removing or adding slides dynamically #103

Closed
wants to merge 8 commits into from

Conversation

zhouqiangWang
Copy link
Contributor

  1. Disable slide (not autocycle) when theres only one image? Disable slide (not autocycle) when theres only one image? #82
  2. Modify PagerIndicator show wrong numbers of indicators when call removeSliderAt
  3. modify ViewPager scroll logic when SliderAdapter data change. avoid slide around a bunch on initializing after removing or adding slides dynamically

1. revert last modification 6bb1164
2. add Indicator.redraw() logic in removeSliderAt
3. add add and delete pager menu for test.


2. Modify PagerIndicator show wrong numbers of indicators when call removeSliderAt
3. modify ViewPager scroll logic when SliderAdapter data change.  avoid slide around a bunch on initializing after removing or adding slides dynamically
merge from daimajia-master
@zhouqiangWang
Copy link
Contributor Author

please help to review this modification.
It fix some logic error about removing or adding slides dynamically.
And I add two menus in the demo to test it,

Actually, there is one more issue about sliding around a bunch sliders after removing or adding dynamically. Now I just disable the smooth animation but it will display blank sometimes.
Do you have any sugguestion?

@daimajia
Copy link
Owner

daimajia commented May 9, 2015

@zhouqiangWang This pull request can not merge automatically, you need to pull the latest code, solve the conflict and then re-push it.

@zhouqiangWang
Copy link
Contributor Author

conflict resolved.

@daimajia
Copy link
Owner

daimajia commented May 9, 2015

When there is only one image slider, it's still cycling.

@zhouqiangWang
Copy link
Contributor Author

@daimajia
Copy link
Owner

@zhouqiangWang Still buggy:

  • When removing slider, there will be a white blank area
  • When there is only one image, it will still able to scroll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants