snappy-framed implementation

[bokken]

Has any thought been given to providing a x-snappy-framed implementation[1]?

I would be willing to provide an implementation if there is interest.

http://code.google.com/p/snappy/source/browse/trunk/format_description.txt

[electrum]

This is the correct link to the framing format: https://code.google.com/p/snappy/source/browse/trunk/framing_format.txt

We're actually the ones who proposed the original framing format that SnappyInputStream / SnappyOutputStream implements. Unfortunately, we haven't had time to update the code to match the current specification.

Contributions are welcome. I think we need to keep compatibility on the InputFormat side for users that have existing compressed data. The current code uses a header of "snappy" whereas the new version uses "sNaPpY", so it should be easy to tell the two formats apart.

[bokken]

I was definitely reading both of those docs and pasted the wrong link. I apologize for the confusion.

To maintain compatibility, would it be sufficient to have a static method, perhaps in the Snappy class, which marks/resets and reads the header bytes to determine which implementation of input stream to use?

Also, is there any value in giving the existing Snappy InputStream/OutputStream a coding name? As long as it is distinct from x-snappy-framed, it would make it possible to (at least through http) clearly differentiate which is being used.

[bokken]

I forked your repo and checked in my changes.

[1] - bokken@0d5a6ef

[bokken]

Is anyone with commit privs monitoring this? Is this project still being maintained?

[bokken]

Any chance of this getting incorporated?

[dain]

Can you add this license header to every file?

/*
 * Copyright (C) 2011 the original author or authors.
 * See the notice.md file distributed with this work for additional
 * information regarding copyright ownership.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

Also we don't use @author tags as they are impossible to keep up to date as the code evolves. Would you be ok with removing them?

[dain]

Actually, I can make the changes if you say ok.

[bokken]

That is fine.
On Jan 24, 2015 2:26 PM, "Dain Sundstrom" notifications@github.com wrote:

Actually, I can make the changes if you say ok.

—
Reply to this email directly or view it on GitHub
#16 (comment).

[dain]

I cleaned up the commit a bit and merged it. Please, let me know if it is working for you and I'll do a release.

[bokken]

I have tested it and everything appears to be good. I have added support to implement nio Channel implementations and utility methods for bulk transfers as part of a pull request.

#27