Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return cli widgets as default if no others are resolved #24

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Return cli widgets as default if no others are resolved #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/daipecore/widgets/CommandLineWidgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from typing import Optional
from daipecore.widgets.Widgets import Widgets
from argparse import ArgumentParser
from daipecore.detector import is_cli


class CommandLineWidgets(Widgets):
Expand Down Expand Up @@ -46,4 +45,4 @@ def get_value(self, name: str):
return value

def should_be_resolved(self):
return is_cli()
return False
7 changes: 5 additions & 2 deletions src/daipecore/widgets/WidgetsFactory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
from typing import List
from daipecore.widgets.Widgets import Widgets
from daipecore.widgets.CommandLineWidgets import CommandLineWidgets


class WidgetsFactory:
def __init__(self, widgets: List[Widgets]):
def __init__(self, widgets: List[Widgets], cli_widgets: CommandLineWidgets):
self.__widgets = widgets
self.__cli_widgets = cli_widgets

def create(self) -> Widgets:
for widget in self.__widgets:
if widget.should_be_resolved():
return widget
raise Exception("No widgets resolved")

return self.__cli_widgets