Cache AppSettings in static class #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure of your preferred style for static stuff... could just as easily be a non-static class with a .Instance if you prefer. |
daishisystems
added a commit
that referenced
this pull request
Oct 2, 2015
Cache AppSettings in static class
|
That’s a very neat optimisation. Thank you! Static class is perfectly fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the AppDomain will automatically recycle when changes are made to the AppSettings (web.config/app.config) it is safe to cache the setting values. This ensures we only do the conversion once and allocate the byte arrays once. This will greatly reduce the number of allocations in the critical path of Filters and Attributes.