Skip to content

Commit

Permalink
Disable validation of intermediary ZedAI in dtbook-to-html and dtbook…
Browse files Browse the repository at this point in the history
…-to-epub3

for now, because px:dtbook-to-zedai is not perfect, but the issues in
the ZedAI do not necessarily result in bad HTML. The real solution is
to fix px:dtbook-to-zedai.
  • Loading branch information
bertfrees committed Jun 19, 2023
1 parent 39e4508 commit 75c7a27
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
8 changes: 5 additions & 3 deletions scripts/dtbook-to-epub3/src/main/resources/xml/convert.xpl
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,11 @@
<p:with-option name="validation" select="$validation"/>
<p:with-option name="dtbook-is-valid" select="$dtbook-is-valid"/>
<!-- reporting validation issues in intermediary documents is not helpful for user -->
<p:with-option name="output-validation" select="if ($validation='abort') then 'abort'
else if ($validation='report' and $dtbook-is-valid) then 'abort'
else 'off'"/>
<!-- FIXME: for now we even completely disabled output validation because px:dtbook-to-zedai
is not perfect, but the issues in the ZedAI do not necessarily result in bad HTML -->
<p:with-option name="output-validation" select="'off'"/> <!--if ($validation='abort') then 'abort'
else if ($validation='report' and $dtbook-is-valid) then 'abort'
else 'off'-->
<p:with-option name="nimas" select="$nimas"/>
</px:dtbook-to-zedai>

Expand Down
8 changes: 5 additions & 3 deletions scripts/dtbook-to-html/src/main/resources/xml/convert.xpl
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,11 @@
<p:with-option name="validation" select="$validation"/>
<p:with-option name="dtbook-is-valid" select="$dtbook-is-valid"/>
<!-- reporting validation issues in intermediary documents is not helpful for user -->
<p:with-option name="output-validation" select="if ($validation='abort') then 'abort'
else if ($validation='report' and $dtbook-is-valid) then 'abort'
else 'off'"/>
<!-- FIXME: for now we even completely disabled output validation because px:dtbook-to-zedai
is not perfect, but the issues in the ZedAI do not necessarily result in bad HTML -->
<p:with-option name="output-validation" select="'off'"/> <!--if ($validation='abort') then 'abort'
else if ($validation='report' and $dtbook-is-valid) then 'abort'
else 'off'-->
<p:with-option name="nimas" select="$nimas"/>
</px:dtbook-to-zedai>

Expand Down

0 comments on commit 75c7a27

Please sign in to comment.