Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for internal display and quick settings submenu #136

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

slaclau
Copy link

@slaclau slaclau commented Apr 22, 2024

Respond to #107

  • Add option for individual sliders in quick settings sub menu Sync all slider to average of individual sliders
  • Add settings items to quick settings sub menu
  • Add functionality to smoothly vary display sliders when changing all slider
  • Add slider for internal display

Copy link
Owner

@daitj daitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments, could you check them and fix it.

@daitj daitj marked this pull request as draft April 25, 2024 21:42
@daitj daitj changed the title Add slider for internal display Support for internal display and quick settings submenu Apr 25, 2024
@slaclau slaclau requested a review from daitj July 1, 2024 09:56
@daitj daitj marked this pull request as ready for review July 1, 2024 12:10
Copy link
Owner

@daitj daitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you haven't pushed the latest changes from your branch, then it will be ready for merging.

@slaclau
Copy link
Author

slaclau commented Jul 1, 2024

This commit should fix the comments you made - 1f21bf3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants