Replace init() by hardcoded standard package names (#29)

* chore: generate std packages mapping * chore: add Makefile
daixiang0 · Jan 11, 2021 · 7eb50f3 · 7eb50f3
1 parent 8f975be
commit 7eb50f3
Show file tree

Hide file tree

Showing 5 changed files with 274 additions and 20 deletions.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,4 @@
+dist/
+.gitcookies
+.idea/
+.vscode/
diff --git a/Makefile b/Makefile
@@ -0,0 +1,18 @@
+.PHONY: clean generate test build
+
+BIN_OUTPUT := $(if $(filter $(shell go env GOOS), windows), dist/gci.exe, dist/gci)
+
+default: clean generate test build
+
+clean:
+	@echo BIN_OUTPUT: ${BIN_OUTPUT}
+	rm -rf dist/ cover.out
+
+build: clean
+	go build -v -trimpath -o ${BIN_OUTPUT} .
+
+test: clean
+	go test -v -cover ./...
+
+generate:
+	go generate ./...
diff --git a/internal/generate.go b/internal/generate.go
diff --git a/pkg/gci/gci.go b/pkg/gci/gci.go
@@ -10,8 +10,6 @@ import (
 	"path/filepath"
 	"sort"
 	"strings"
-
-	"golang.org/x/tools/go/packages"
 )
 
 const (
@@ -28,29 +26,11 @@ var (
 	importStartFlag = []byte(`
 import (
 `)
-
 	importEndFlag = []byte(`
 )
 `)
-	standardPackages = make(map[string]struct{})
 )
 
-func init() {
-	pkgs, err := packages.Load(nil, "std")
-	if err != nil {
-		panic(err)
-	}
-
-	for _, p := range pkgs {
-		standardPackages[p.PkgPath] = struct{}{}
-	}
-}
-
-func isStandardPackage(pkg string) bool {
-	_, ok := standardPackages[pkg]
-	return ok
-}
-
 type FlagSet struct {
 	LocalFlag       string
 	DoWrite, DoDiff *bool

diff --git a/pkg/gci/std.go b/pkg/gci/std.go