Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify implemented Kyber version #33

Open
larabr opened this issue Jan 31, 2024 · 4 comments · May be fixed by #34
Open

Clarify implemented Kyber version #33

larabr opened this issue Jan 31, 2024 · 4 comments · May be fixed by #34

Comments

@larabr
Copy link

larabr commented Jan 31, 2024

I assume this is implementing version 3 (as opposed to e.g. the NIST version), as that's stated by https://github.com/antontutoveanu/crystals-kyber-javascript . But I didn't find specific info about this.
Is the assumption correct? If so, do you have plans to implement the NIST draft version (https://csrc.nist.gov/pubs/fips/203/ipd)?

@dajiaji
Copy link
Owner

dajiaji commented Jan 31, 2024

Your assumption is correct, and I also recognized the need to follow the NIST draft (ML-KEM).
However, I still do not understand the difference between v3 and ML-KEM...

@larabr
Copy link
Author

larabr commented Jan 31, 2024

The differences are listed in page 2 of the NIST draft 🙂

@larabr
Copy link
Author

larabr commented Feb 29, 2024

FYI I've implemented the ML-KEM changes here, in case you want to apply them to this repo too (I could also open a PR; we still need to maintain a separate fork to support browsers without native BigInts).

@dajiaji
Copy link
Owner

dajiaji commented Mar 3, 2024

@larabr Thanks for your information.

Although I'd like you to send a PR to merge your updates including the support for old browsers here, it is probably a tedious work for you, so I will try to merge them to some extent on my end.

@dajiaji dajiaji linked a pull request Mar 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants