Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ML-KEM. #34

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add support for ML-KEM. #34

wants to merge 9 commits into from

Conversation

dajiaji
Copy link
Owner

@dajiaji dajiaji commented Mar 3, 2024

Close #33

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 93.35%. Comparing base (2cb48a3) to head (b69cd0f).

Files Patch % Lines
src/kyberBase.ts 70.37% 8 Missing ⚠️
src/utils.ts 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   94.57%   93.35%   -1.22%     
==========================================
  Files           8        9       +1     
  Lines        1105     1129      +24     
  Branches       84       96      +12     
==========================================
+ Hits         1045     1054       +9     
- Misses         60       75      +15     
Flag Coverage Δ
unittests 93.35% <75.00%> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@larabr larabr Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test browser changes are probs not needed -- we just had to make them to avoid setting up GH pages on our side, and to be able test legacy browsers.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. I also thought that this change was not necessary. I was considering rolling it back, but I got busy and ended up stopping the work halfway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify implemented Kyber version
3 participants