-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ML-KEM. #34
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 94.57% 93.35% -1.22%
==========================================
Files 8 9 +1
Lines 1105 1129 +24
Branches 84 96 +12
==========================================
+ Hits 1045 1054 +9
- Misses 60 75 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test browser changes are probs not needed -- we just had to make them to avoid setting up GH pages on our side, and to be able test legacy browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review. I also thought that this change was not necessary. I was considering rolling it back, but I got busy and ended up stopping the work halfway.
Close #33