Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented DeriveKeyPair #133

Merged
merged 16 commits into from Oct 27, 2023
Merged

implemented DeriveKeyPair #133

merged 16 commits into from Oct 27, 2023

Conversation

Aurvandill
Copy link
Contributor

relates to issue #9

@Aurvandill
Copy link
Contributor Author

Aurvandill commented Oct 26, 2023

perhabps i should move the derive_key_pair Function from the KEM class to the corresponding KEMPrimitvesInterface (eg. EC, X25519, X448) subclass.
what's your opinion on that @dajiaji

@Aurvandill
Copy link
Contributor Author

@dajiaji did you already have time to take a look?

@dajiaji
Copy link
Owner

dajiaji commented Oct 27, 2023

Thanks for your contribution!

I'll check your PR now.

pyhpke/__init__.py Outdated Show resolved Hide resolved
@dajiaji
Copy link
Owner

dajiaji commented Oct 27, 2023

perhabps i should move the derive_key_pair Function from the KEM class to the corresponding KEMPrimitvesInterface (eg. EC, X25519, X448) subclass. what's your opinion on that @dajiaji

Thanks. I'm very happy if you could move it to the subclasses of KEPrimitivesInterface.

@Aurvandill
Copy link
Contributor Author

ok i will move it into the KEMPrimitivesInterface and revert the version bump later today :)
thanks for taking a look

@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (bd7748a) 86.70% compared to head (feb6b1c) 87.24%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   86.70%   87.24%   +0.54%     
==========================================
  Files          29       29              
  Lines         782      839      +57     
==========================================
+ Hits          678      732      +54     
- Misses        104      107       +3     
Files Coverage Δ
pyhpke/kem.py 94.87% <100.00%> (+0.13%) ⬆️
pyhpke/kem_primitives/x25519.py 100.00% <100.00%> (+4.16%) ⬆️
pyhpke/kem_primitives/x448.py 100.00% <100.00%> (+4.16%) ⬆️
pyhpke/kem_primitives_interface.py 57.89% <100.00%> (+2.33%) ⬆️
pyhpke/kem_interface.py 66.66% <50.00%> (-2.09%) ⬇️
pyhpke/kem_key_interface.py 81.81% <50.00%> (-7.08%) ⬇️
pyhpke/keys/ec_key.py 70.49% <80.00%> (+0.31%) ⬆️
pyhpke/keys/x25519_key.py 81.81% <75.00%> (-0.69%) ⬇️
pyhpke/keys/x448_key.py 81.81% <75.00%> (-0.69%) ⬇️
pyhpke/kem_primitives/ec.py 88.13% <85.18%> (-0.44%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aurvandill
Copy link
Contributor Author

@dajiaji I'm done with the changes :)

@dajiaji
Copy link
Owner

dajiaji commented Oct 27, 2023

Thanks for the great work! Approved.

@dajiaji dajiaji merged commit e81023b into dajiaji:main Oct 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants