New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented DeriveKeyPair #133
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
perhabps i should move the |
@dajiaji did you already have time to take a look? |
Thanks for your contribution! I'll check your PR now. |
Thanks. I'm very happy if you could move it to the subclasses of |
ok i will move it into the |
This reverts commit ef7f343.
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 86.70% 87.24% +0.54%
==========================================
Files 29 29
Lines 782 839 +57
==========================================
+ Hits 678 732 +54
- Misses 104 107 +3
☔ View full report in Codecov by Sentry. |
@dajiaji I'm done with the changes :) |
Thanks for the great work! Approved. |
relates to issue #9