Replace passlib with argon2-cffi #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@dmgawel Thanks for your contribution! I'll check your PR today. Wait for a while. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 14 14
Lines 1365 1365
=======================================
Hits 1348 1348
Misses 17 17
☔ View full report in Codecov by Sentry. |
dajiaji
approved these changes
Oct 3, 2023
|
Thanks for looking into this, @dajiaji! I'd appreciate tagging a new release with this change included 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passliblibrary used for argon2 hashing appears unmaintained and causes deprecation warning forcryptmodule. This PR replaces passlib withargon2-cffi, which is used by passlib under the hood.Resolves #314