Add ECDH-ES+AES-KW test #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
=======================================
Coverage 97.37% 97.38%
=======================================
Files 32 32
Lines 3244 3246 +2
=======================================
+ Hits 3159 3161 +2
Misses 85 85
☔ View full report in Codecov by Sentry. |
dajiaji
approved these changes
Oct 11, 2023
|
Thank you for your contribution. LGTM. |
|
I'm glad I could help you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ECDH-ES+AES-KW key agreement and {AES-CTR, AES-CBC} encryption test.
8106acb is related to #439 .
It is required to be applied, otherwise
sender.encode()causes an errorValueError: Invalid alg in recipients' context information: -3.