New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new getter functions: rasqal_graph_pattern_get_triples, rasqal_literal_get_type, rasqal_literal_get_language #1

Merged
merged 5 commits into from Oct 19, 2014

Conversation

Projects
None yet
2 participants
@cosminbasca
Contributor

cosminbasca commented May 13, 2014

I've created 3 new simplistic getters for accessing private members of the rasqal_literal and rasqal_graph_pattern structs. The rasqal_graph_pattern_get_triples creates a new raptor_sequence containing only the triples of the graph pattern, or NULL if no triple patterns are contained in the respective graph pattern. The functions pertinent to the rasqal_literal struct are exposing the type and language members with minimal checks.

@dajobe

This comment has been minimized.

Show comment
Hide comment
@dajobe

dajobe May 13, 2014

Owner

This looks good but you need to undo the changes to the sgml files - they aren't correct and I can do those for the new functions automatically.

Adding new functions also needs updating the docs pointers in docs/*tsv and the sections files - which I generally do - but if you want to have a go at that, feel free.

Owner

dajobe commented May 13, 2014

This looks good but you need to undo the changes to the sgml files - they aren't correct and I can do those for the new functions automatically.

Adding new functions also needs updating the docs pointers in docs/*tsv and the sections files - which I generally do - but if you want to have a go at that, feel free.

@cosminbasca

This comment has been minimized.

Show comment
Hide comment
@cosminbasca

cosminbasca May 14, 2014

Contributor

I think the sgml files were automatically modified when I ran autogen.sh. I will revert the sgml files. I would rather have you modify the documentation pointers since I am less experienced with the build / release system used in rasqal rasqal than you :). Thanks!

Contributor

cosminbasca commented May 14, 2014

I think the sgml files were automatically modified when I ran autogen.sh. I will revert the sgml files. I would rather have you modify the documentation pointers since I am less experienced with the build / release system used in rasqal rasqal than you :). Thanks!

@dajobe

View changes

Show outdated Hide outdated src/rasqal_graph_pattern.c
raptor_sequence* triples = NULL;
int i = 0;
if (graph_pattern->triples) {

This comment has been minimized.

@dajobe

dajobe May 14, 2014

Owner

code style. I'd move 'int i;' to here at the start of this block. it doesn't need setting to 0 either since it's initialized below.

@dajobe

dajobe May 14, 2014

Owner

code style. I'd move 'int i;' to here at the start of this block. it doesn't need setting to 0 either since it's initialized below.

This comment has been minimized.

@cosminbasca

cosminbasca May 14, 2014

Contributor

true, sounds good

@cosminbasca

cosminbasca May 14, 2014

Contributor

true, sounds good

dajobe added a commit that referenced this pull request Oct 19, 2014

Merge pull request #1 from cosminbasca/master
new getter functions: rasqal_graph_pattern_get_triples, rasqal_literal_get_type, rasqal_literal_get_language

@dajobe dajobe merged commit 80633c4 into dajobe:master Oct 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment