Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new getter functions: rasqal_graph_pattern_get_triples, rasqal_literal_get_type, rasqal_literal_get_language #1

Merged
merged 5 commits into from Oct 19, 2014

Conversation

cosminbasca
Copy link
Contributor

I've created 3 new simplistic getters for accessing private members of the rasqal_literal and rasqal_graph_pattern structs. The rasqal_graph_pattern_get_triples creates a new raptor_sequence containing only the triples of the graph pattern, or NULL if no triple patterns are contained in the respective graph pattern. The functions pertinent to the rasqal_literal struct are exposing the type and language members with minimal checks.

@dajobe
Copy link
Owner

dajobe commented May 13, 2014

This looks good but you need to undo the changes to the sgml files - they aren't correct and I can do those for the new functions automatically.

Adding new functions also needs updating the docs pointers in docs/*tsv and the sections files - which I generally do - but if you want to have a go at that, feel free.

@cosminbasca
Copy link
Contributor Author

I think the sgml files were automatically modified when I ran autogen.sh. I will revert the sgml files. I would rather have you modify the documentation pointers since I am less experienced with the build / release system used in rasqal rasqal than you :). Thanks!

raptor_sequence* triples = NULL;
int i = 0;

if (graph_pattern->triples) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code style. I'd move 'int i;' to here at the start of this block. it doesn't need setting to 0 either since it's initialized below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, sounds good

dajobe added a commit that referenced this pull request Oct 19, 2014
new getter functions: rasqal_graph_pattern_get_triples, rasqal_literal_get_type, rasqal_literal_get_language
@dajobe dajobe merged commit 80633c4 into dajobe:master Oct 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants