-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv6 addresses often mistaken as line/column numbers #146
Comments
Thanks for the report. Yes I think the |
After some testing I think |
Thank you for looking into it. I really appreciate it. Yeah I figured having Like I said above I'd be perfectly fine with not allowing The one exception that comes to mind is maildir directories. Soooo… maybe making it configurable would be best? Or even toggle-able from the |
This is causing troubles with line:column like patterns in files gaining traction from ipv6 adoption. Let's just parse the filename up until the first ':' here to improve the situation.
Pushed a fix now without configuration possibilities. Let's add that if people request it. |
When I search for something & one of the result lines contains an IPv6 address,
rg.el
mistakes parts of them as the line & column number patters. For example, if I have the following whole line visible in*rg*
:and I press enter on it, Emacs asks me for the path to the file to visit with a nonsensical default:
The problem seems to be that the regular expressions used for building
compilation-error-regexp-alist
is too greedy.I'm well aware that there's no 100% correct way of splitting
rg
's output (or maybe there is using the-0
arg…). Personally I'd very much like to be able to make the file name part non-greedy as I 100% never have file names with colons in them followed directly by numbers.The text was updated successfully, but these errors were encountered: