Fix "File: " skipping when building the elements of the imenu #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarrientos
force-pushed
the
imenu_skip
branch
2 times, most recently
from
151684f
to
5dcafd1
Compare
We shouldn't be using `skip-chars-forward' here as this function skips over any _character set_ passed as argument, not just a string. Without this patch, for instance entries like: File: lol/foo.bar Will be added to the candidates list as "ol/foo.bar" as ?l is in the character set "File: ". Instead, just skips 6 chars forward.
nbarrientos
force-pushed
the
imenu_skip
branch
2 times, most recently
from
a5033fa
to
715fe33
Compare
|
Looks good. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be using
skip-chars-forwardhere as this function skips over any character set passed as argument, not just a string.Without this patch, for instance entries like:
Will be added to the candidates list as "ol/foo.bar" as
?lis in the character set "File: ".Instead, just skips 6 chars forward.
Sorry for this, I should have read the documentation of the function instead of just relying on the name grins. I've added an integration test to make this (hopefully) regression-proof.