-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend rg-define-search :format to accept lisp form #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. Looks great.
Documentation also needs to change in docs/configuration.org.
rg.el
Outdated
(eval-when-compile | ||
;; parse :format arg, default (non-nil) means to use regexp, otherwise | ||
;; do a literal search | ||
(defsubst rg--parse-format-literal (format-opt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package does not use --
convention for internal defs.
Sure, are you OK with the documentation I added in the code, ie. the following
|
Yes, that will be super. |
And you don't need to bother with generating the info file. I can do that separately. Thanks. |
K, added docs and fixed subr name. Thanks! |
Thanks |
Extends
:format
argument to allow evaluation of lisp form,but still respects
literal
andregexp
symbols. Thus, a search functionthat could replace projectile's ripgrep function could look like (search literal with no
prefix, regexp with a prefix) -- closes #74