Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"f" for "Forward" collides with "Change files" binding #81

Merged
merged 1 commit into from
May 7, 2020

Conversation

mjs
Copy link
Contributor

@mjs mjs commented May 2, 2020

Also fixed doubled up label for history bindings ("Back" was used twice).

@mjs
Copy link
Contributor Author

mjs commented May 2, 2020

I chose some bindings that made sense to me but I'm open to other ideas.

@mjs mjs changed the title "f" for forward collides with "Change files" binding "f" for "Forward" collides with "Change files" binding May 2, 2020
@coveralls
Copy link

coveralls commented May 2, 2020

Coverage Status

Coverage remained the same at 83.362% when pulling 72f1f40 on mjs:fix-history-bindings into e19c06f on dajva:master.

@dajva
Copy link
Owner

dajva commented May 3, 2020

Oh, how did I miss that. Thanks for fixing it. :)

Some comments:

  1. Still want the labels to be "Back" and "Forward" since that is the terminology that is used throughout the package.
  2. Regarding the bindings, I think we can keep 'b' since that is not taken. I would suggest using 'w' for forward since that may give some kind of mnemonic with 'w' in forward and is also on the left hand to ease the combination with the 'm' menu key. For evil users it's also a familiar binding for moving forward.

@mjs
Copy link
Contributor Author

mjs commented May 4, 2020

Done!

@dajva dajva merged commit 5df98ad into dajva:master May 7, 2020
@dajva
Copy link
Owner

dajva commented May 7, 2020

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants