Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve templating logic #48

Closed
dakusui opened this issue Sep 28, 2019 · 0 comments
Closed

Improve templating logic #48

dakusui opened this issue Sep 28, 2019 · 0 comments
Assignees
@dakusui
Labels
enhancement New feature or request

Comments

@dakusui
Copy link
Owner

dakusui commented Sep 28, 2019 •
edited
Loading

Right now, references in a string node is expanded in a following order and logic.

  1. Before templating, all the file-level and node-level inheritances are expanded and we have a big JSON file.
  2. All the nodes in the big JSON file are soreted by the depth and then the name of the nodes in dictionary order.
  3. Those nodes are scanned one by one and templating happens for each.

With this mechanism user can know and to some extent control how templating happens in case a node contains $(ref) command.

However, we ultimately want to make it possible to reference a node from another without noticing such mechanism while in case a cyclic reference is warned as an error.
@dakusui dakusui self-assigned this Sep 28, 2019
@dakusui dakusui added the enhancement New feature or request label Sep 28, 2019
@dakusui dakusui closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakusui dakusui

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dakusui