Bugfix: Make Solax no longer get stuck with open contactors at 0%SOC #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsc
reviewed
Mar 18, 2024
rjsc
requested changes
Mar 18, 2024
rjsc
approved these changes
Mar 18, 2024
|
@rjsc did you test this change already, or just merge it? 😅 |
|
Just reviewed the code and merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR makes Solax inverters more robust on double LilyGo setups
Why
Solax inverters opens the contactors if the battery is at the minimum charge level but there is no PV power available or grid power allowed to charge it. This is a problem, since we have been treating it as an ERROR, requiring reboot to get out of this state.
How