Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Increase size for data #247

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Improvement: Increase size for data #247

merged 4 commits into from
Apr 7, 2024

Conversation

dalathegreat
Copy link
Owner

What

This PR allows for storing larger values;

  • Instant Watt values can now go over +-60kW ( +-200kW)
  • Max charge/discharge can now go over 60kW (-> 200kW)
  • Battery size comment updated to 500kWh
  • Battery voltage comments updated from 500V -> 1000V

Why

To prepare for double battery support, and larger batteries

How

uint16->uint32 mostly!

Cabooman
Cabooman approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@Cabooman Cabooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Using unstructured global variables really doesn't scale lol

@dalathegreat dalathegreat merged commit c5118a8 into main Apr 7, 2024
42 checks passed
@dalathegreat dalathegreat deleted the feature/increase-datatypes branch April 7, 2024 20:21
@dalathegreat dalathegreat mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cabooman Cabooman Cabooman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dalathegreat @Cabooman