Add debug functions for can fd #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 5, 2024 19:53
dalathegreat
requested changes
May 5, 2024
| canfd.tryToSend(frame); | ||
| #endif | ||
| } | ||
| #ifdef DEBUG_CANFD_DATA |
There was a problem hiding this comment.
Could I suggest moving this out to Software.ino instead? That way it could be used for all CAN-FD protocols. I have been thinking about doing the same for the normal CAN debug mode
There was a problem hiding this comment.
Added the DEBUG_CANFD_DATA functions to Software.ino
dalathegreat
reviewed
May 6, 2024
Software/Software.ino
Outdated
| Serial.println(" "); | ||
| } | ||
|
|
||
| void debug_canfd_frame(CANFDMessage frame) { |
There was a problem hiding this comment.
One more suggestion, would be better if we only kept the print_canfd_frame function, and skipped the debug_canfd_frame in Software.ino!
There was a problem hiding this comment.
Merged the two functions into one.
dalathegreat
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds settings to enable can fd debugging.
Why
To improve ease of access to can fd data in serial monitor.
How
Enabling #define DEBUG_CANFD_DATA in USER_SETTINGS.h then it starts to print out frames from can fd data stream.