-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug functions for can fd #289
Conversation
canfd.tryToSend(frame); | ||
#endif | ||
} | ||
#ifdef DEBUG_CANFD_DATA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could I suggest moving this out to Software.ino instead? That way it could be used for all CAN-FD protocols. I have been thinking about doing the same for the normal CAN debug mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the DEBUG_CANFD_DATA functions to Software.ino
Software/Software.ino
Outdated
Serial.println(" "); | ||
} | ||
|
||
void debug_canfd_frame(CANFDMessage frame) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more suggestion, would be better if we only kept the print_canfd_frame
function, and skipped the debug_canfd_frame
in Software.ino!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged the two functions into one.
What
This PR adds settings to enable can fd debugging.
Why
To improve ease of access to can fd data in serial monitor.
How
Enabling #define DEBUG_CANFD_DATA in USER_SETTINGS.h then it starts to print out frames from can fd data stream.