Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github bookmark error #15

Closed
Jogai opened this issue Mar 17, 2022 · 2 comments
Closed

Github bookmark error #15

Jogai opened this issue Mar 17, 2022 · 2 comments
Labels
bug Something isn't working verified This bug can be recreated

Comments

@Jogai
Copy link

Jogai commented Mar 17, 2022

This bookmark:

{
    "name": "Github",
    "url" : "https://github.com/notifications?query=is%3Aunread"
},

Results in this error:

GET http://start.ho.me/api/icon.php?siteurl=https://github.com/notifications?query=is%3Aunread 500 (Internal Server Error)
VM33:1 Uncaught (in promise) SyntaxError: Unexpected end of JSON input
daledavies added a commit that referenced this issue Mar 18, 2022
@daledavies
Issue #15: Properly encode and escape URLs with query params
b0b9b31
@daledavies daledavies added the bug Something isn't working label Mar 18, 2022
@daledavies
Copy link
Owner

I've pushed a patch that will fix this, will be available in the v1.1.2 release :)

@daledavies
Copy link
Owner

Release v1.1.2 has been created, images on docker hub etc, so closing this issue. Thank you for raising.

@daledavies daledavies added the verified This bug can be recreated label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working verified This bug can be recreated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jogai @daledavies