You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've added an option to disable SSL cert verification on a per-site basis for the status checker.
I'm not sure what to do about the favicons, I'd prefer not to modify the third part library. Feel free to raise an issue/make a pull request to their repo and let me know if it get's updated. Probably not the answer you were hoping for but for now I'd suggest using a custom icon for this site as per the docs here... https://github.com/daledavies/jump#icons
The per-site options willbe made available in the next release, just looking to see if I can tick off any more issues before I put it all together.
This has been included in the latest v1.3.1 release today, you can pull this from Docker Hub using either the daledavies/jump:latest or daledavies/jump:v1.3.1 tags.
I am loving Jump as my new start page. I added all my self hosted applications and noticed that Jump does not handle self signed certificates well. First in the status checker this line:
https://github.com/daledavies/jump/blob/main/jumpapp/classes/Status.php#L46
starts the GuzzleHttp client and needs an option to allow unverified certs. See: https://docs.guzzlephp.org/en/stable/request-options.html#verify
Additionally the get Favicon function also does not respect HTTPS self signed certs.
Line which gets the Favicon: https://github.com/daledavies/jump/blob/main/jumpapp/classes/Site.php#L72
I understand you are using a third part library for this (https://github.com/ArthurHoaro/favicon). I found this area https://github.com/ArthurHoaro/favicon/blob/master/src/Favicon/DataAccess.php#L37 which needs to be changed to allow HTTPS. (See https://www.php.net/manual/en/context.ssl.php)
Thanks!
The text was updated successfully, but these errors were encountered: