Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS errors #69

Closed
StrongWind1 opened this issue Jan 6, 2023 · 2 comments
Closed

HTTPS errors #69

StrongWind1 opened this issue Jan 6, 2023 · 2 comments
Labels

Comments

@StrongWind1
Copy link

I am loving Jump as my new start page. I added all my self hosted applications and noticed that Jump does not handle self signed certificates well. First in the status checker this line:
https://github.com/daledavies/jump/blob/main/jumpapp/classes/Status.php#L46
starts the GuzzleHttp client and needs an option to allow unverified certs. See: https://docs.guzzlephp.org/en/stable/request-options.html#verify

Additionally the get Favicon function also does not respect HTTPS self signed certs.
Line which gets the Favicon: https://github.com/daledavies/jump/blob/main/jumpapp/classes/Site.php#L72

I understand you are using a third part library for this (https://github.com/ArthurHoaro/favicon). I found this area https://github.com/ArthurHoaro/favicon/blob/master/src/Favicon/DataAccess.php#L37 which needs to be changed to allow HTTPS. (See https://www.php.net/manual/en/context.ssl.php)

Thanks!

@daledavies
Copy link
Owner

I've added an option to disable SSL cert verification on a per-site basis for the status checker.

I'm not sure what to do about the favicons, I'd prefer not to modify the third part library. Feel free to raise an issue/make a pull request to their repo and let me know if it get's updated. Probably not the answer you were hoping for but for now I'd suggest using a custom icon for this site as per the docs here... https://github.com/daledavies/jump#icons

The per-site options willbe made available in the next release, just looking to see if I can tick off any more issues before I put it all together.

@daledavies
Copy link
Owner

This has been included in the latest v1.3.1 release today, you can pull this from Docker Hub using either the daledavies/jump:latest or daledavies/jump:v1.3.1 tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants