Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Pharo-2.0 as environment #12

Closed
dalehenrich opened this issue Jun 26, 2012 · 20 comments
Closed

add Pharo-2.0 as environment #12

dalehenrich opened this issue Jun 26, 2012 · 20 comments

Comments

@dalehenrich
Copy link
Owner

need to get Metacello scripting api working there first

@dalehenrich
Copy link
Owner Author

tests won't be passing until bug in Pharo-2.0 fixed to allow progress on Metacello port, but I can get the infrastructure in place

dalehenrich pushed a commit that referenced this issue Jul 6, 2012
dalehenrich pushed a commit that referenced this issue Jul 6, 2012
port to Pharo-2.0 not complete at this writing)
@dalehenrich
Copy link
Owner Author

need to add new Cog vm for Pharo-2.0 then undo commit

@dalehenrich
Copy link
Owner Author

need to fix FileTree issue 52

@dalehenrich
Copy link
Owner Author

newest Cog vm added

@dalehenrich
Copy link
Owner Author

Pharo-2.0 implementation poised... FileTree issue 52

@dalehenrich
Copy link
Owner Author

for Pharo-2.0 need to use FileSystem instead of FileTree ... have to scrub the scripts ...

dalehenrich pushed a commit that referenced this issue Aug 11, 2012
dalehenrich pushed a commit that referenced this issue Aug 11, 2012
@dalehenrich
Copy link
Owner Author

clean builds ... time to merge issue_12 back into the master

dalehenrich pushed a commit that referenced this issue Aug 11, 2012
dalehenrich pushed a commit that referenced this issue Aug 31, 2012
look to flush out more issues ...
dalehenrich pushed a commit that referenced this issue Aug 31, 2012
@frankshearar
Copy link

I just took this branch for a spin and you can see the results here. Progress! New error!

./build.sh: line 198:  2254 Killed
exec "$PHARO_VM" $PHARO_PARAM "$OUTPUT_IMAGE" "$OUTPUT_SCRIPT

It looks at first glance like a kill-cos-it-took-too-long?

@dalehenrich
Copy link
Owner Author

Actually it turns out that phar2.0 shouldn't be run in the background (talked to Cami and Esteban during ESUG), but there are other issues with 2.0 that should be cleaned up by the end of next week, so I'll wait til then to try again:)

@dalehenrich
Copy link
Owner Author

In order to stay sane, I think that I will have to create a branch for pharo2.0 ... need a new vm (and who know s how often one will be needed) a bunch of the scripts have to change ... better off isolating all of this stuff in a separate branch ... then I can simplify a bunch of the scripts where FileSystem/FileDirectory stuff already filtered in

@dalehenrich
Copy link
Owner Author

dalehenrich pushed a commit that referenced this issue May 7, 2013
@dalehenrich
Copy link
Owner Author

@demary, check out this green Pharo-2.0 test!

We are very close! Good effort!

@dalehenrich
Copy link
Owner Author

all platforms green, including Pharo2.0 ... call this one closed

@dalehenrich
Copy link
Owner Author

see https://github.com/dalehenrich/metacello-work/pull/161 ... we need a set of FileSystem/FileDirectory compat methods that can be used in scripts to do file/directory manipulations in a platform independent manner ...

@frankshearar
Copy link

This problem would show up like this?

===============================================================================
Notice: Errors in script loaded from /home/travis/dalehenrich-builderCI-1554a6e/builds/travisCI/travisCI.st
===============================================================================
==== Startup Error: MessageNotUnderstood: receiver of "default" is nil
UndefinedObject(Object)>>doesNotUnderstand: #default

@frankshearar
Copy link

Camillo Bruni wrote a shim that makes FileSystem expose a FileDirectory compatible API...

@dalehenrich
Copy link
Owner Author

I'm aware of Cami's (@dh83) shim class, but I need to be careful about limiting dependencies like that for builderCI ... the Pharo folks have gone to a lot of effort to eliminate FileDirectory from the image, but if all of a sudden builderCI re-introduces FileDirectory then tests against Pharo-2.0 won't fail if code inadvertantly references FileDirectory ... Consequently I've had to invent my own FileDirectory shims for each of my cross-platform projects ...

@camillobruni
Copy link

The compatibility package should not be used in any production environment. It's sole purpose is to easy migration in 2.0 from FileDirectory code to FileSystem code. BTW you should check what Sven did in Zinc, since he had to write a little compatibility layer himself.

@dalehenrich
Copy link
Owner Author

I did and came to the conclusion that I didn't want a dependency on Zinc's compatibility layer either ...

FileTree has it's own compat layer ...

Christophe and I created a set of compatibility methods in the MetacelloPlatform class for Metacello, but builderCI also needs a compatibility layer ... we started by using the MetacelloPlatform api, but the file manipulation code in a builderCI script can be hit before Metacello is loaded ...

So we will have to copy the methods from MetacelloPlatform and create a builderCI platform class ...

@dalehenrich
Copy link
Owner Author

Done for a bit ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants