Issue Metacello#328: proposed fix ... implement and use MetacelloProj…

…ectRegistrationVersionInfo>>setVersionString:
dalehenrich · Feb 14, 2015 · f7312e0 · f7312e0
1 parent 678375c
commit f7312e0
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 5 deletions.
diff --git a/...-Core.package/MetacelloProjectRegistrationVersionInfo.class/instance/setVersionString..st b/...-Core.package/MetacelloProjectRegistrationVersionInfo.class/instance/setVersionString..st
@@ -0,0 +1,5 @@
+accessing
+setVersionString: anObject
+  "set versionString, only if it does not already have avalue"
+
+  versionString ifNil: [ self versionString: anObject ]
diff --git a/...etacello-Core.package/MetacelloProjectRegistrationVersionInfo.class/methodProperties.json b/...etacello-Core.package/MetacelloProjectRegistrationVersionInfo.class/methodProperties.json
@@ -4,5 +4,6 @@
 	"instance" : {
 		"projectVersion" : "dkh 08/11/2014 07:00",
 		"projectVersion:" : "dkh 08/11/2014 07:01",
+		"setVersionString:" : "dkh 02/14/2015 07:52",
 		"versionString" : "dkh 05/08/2014 11:31",
 		"versionString:" : "dkh 08/20/2014 07:32" } }
diff --git a/...ello-Core.package/MetacelloProjectRegistry.class/instance/registerProjectRegistration..st b/...ello-Core.package/MetacelloProjectRegistry.class/instance/registerProjectRegistration..st
@@ -21,7 +21,7 @@ registerProjectRegistration: aMetacelloProjectRegistration
           spec versionString: version versionString ].
       aMetacelloProjectRegistration configurationProjectSpec: spec.
       (aMetacelloProjectRegistration respondsTo: #'versionInfo')
-        ifTrue: [ aMetacelloProjectRegistration versionInfo versionString: spec versionString ].
+        ifTrue: [ aMetacelloProjectRegistration versionInfo setVersionString: spec versionString ].
       spec immutable.
       self configurationRegistry
         at: spec className
@@ -42,7 +42,7 @@ registerProjectRegistration: aMetacelloProjectRegistration
       (aMetacelloProjectRegistration respondsTo: #'versionInfo')
         ifTrue: [ 
           aMetacelloProjectRegistration versionInfo
-            versionString: spec repositoryVersionString ].
+            setVersionString: spec repositoryVersionString ].
       spec immutable.
       self baselineRegistry
         at: spec className

diff --git a/repository/Metacello-Core.package/MetacelloProjectRegistry.class/methodProperties.json b/repository/Metacello-Core.package/MetacelloProjectRegistry.class/methodProperties.json
@@ -17,7 +17,7 @@
 		"primeRegistryProjectSpecRegistered:" : "dkh 05/07/2014 14:46",
 		"projectSpecForClassNamed:ifAbsent:" : "dkh 7/19/2012 11:14",
 		"projectSpecs" : "dkh 7/19/2012 11:13",
-		"registerProjectRegistration:" : "dkh 09/04/2014 09:54",
+		"registerProjectRegistration:" : "dkh 02/14/2015 07:52",
 		"registrationFor:ifPresent:ifAbsent:" : "dkh 7/19/2012 11:30",
 		"registrationForClassNamed:ifAbsent:" : "dkh 05/14/2014 07:06",
 		"registrationForExactClassNamed:ifAbsent:" : "dkh 05/14/2014 07:05",

diff --git a/.../Metacello-Core.package/MetacelloScriptGitBasedDownloadNotification.class/properties.json b/.../Metacello-Core.package/MetacelloScriptGitBasedDownloadNotification.class/properties.json
@@ -4,7 +4,7 @@
 		 ],
 	"classvars" : [
 		 ],
-	"commentStamp" : "dkh 09/29/2014 12:27",
+	"commentStamp" : "",
 	"instvars" : [
 		"projectPath",
 		"versionString" ],

diff --git a/repository/Metacello-Core.package/monticello.meta/version b/repository/Metacello-Core.package/monticello.meta/version