Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize inner-product prover by inlining adjustment scalars #80

Closed
hdevalence opened this issue Apr 30, 2018 · 0 comments · Fixed by #178
Closed

Optimize inner-product prover by inlining adjustment scalars #80

hdevalence opened this issue Apr 30, 2018 · 0 comments · Fixed by #178
Assignees
@cathieyun
Labels
E-medium good first issue help wanted P-low T-optimization Making things faster/smaller
Milestone
0.2

Comments

@hdevalence
Copy link
Contributor

See comment here: https://github.com/chain/ristretto-bulletproofs/blob/main/src/inner_product_proof.rs#L62

The inputs to the function include a vector of points H, and adjustment scalars hprime_factors. The proof is supposed to be formed with respect to H' defined as H'[i] = hprime_factors[i] * H[i].

Right now, to do this, the H points are multiplied by the adjustment scalars, which is inefficient, since they could be combined into the formulas further down (scalar*scalar operations are essentially free compared to scalar * point operations).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cathieyun cathieyun

Labels
E-medium good first issue help wanted P-low T-optimization Making things faster/smaller
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

Optimize inner-product prover by inlining adjustment scalars dalek-cryptography/bulletproofs
2 participants
@hdevalence @cathieyun