Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize inner-product prover by inlining adjustment scalars #178

Merged
merged 5 commits into from
Sep 27, 2018
Merged

Optimize inner-product prover by inlining adjustment scalars #178

merged 5 commits into from
Sep 27, 2018

Conversation

cathieyun
Copy link
Member

closes #80

@cathieyun cathieyun added PTAL Ready for peer review T-optimization Making things faster/smaller labels Sep 27, 2018
@hdevalence
Copy link
Contributor

Testing on zoomzoom it seems like this gives a nice boost:

Aggregated 64-bit rangeproof creation/1                                                                           
                        time:   [7.4204 ms 7.4225 ms 7.4245 ms]
                        change: [-18.801% -18.769% -18.739%] (p = 0.00 < 0.05)
                        Performance has improved.
Aggregated 64-bit rangeproof creation/2                                                                           
                        time:   [14.255 ms 14.258 ms 14.264 ms]
                        change: [-18.951% -18.882% -18.809%] (p = 0.00 < 0.05)
                        Performance has improved.
Aggregated 64-bit rangeproof creation/4                                                                           
                        time:   [28.236 ms 28.374 ms 28.595 ms]
                        change: [-19.914% -19.559% -19.289%] (p = 0.00 < 0.05)
                        Performance has improved.

hdevalence
hdevalence reviewed Sep 27, 2018
View reviewed changes
src/inner_product_proof.rs
.map(|(b_R_i, y_i)| b_R_i * y_i),
).chain(iter::once(c_L)),
G_R.iter().chain(H_L.iter()).chain(iter::once(Q)),
).compress();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

hdevalence
hdevalence approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdevalence hdevalence merged commit ab699db into main Sep 27, 2018
@hdevalence hdevalence deleted the inline-hprime branch September 27, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdevalence hdevalence hdevalence approved these changes

@oleganza oleganza Awaiting requested review from oleganza

Assignees
No one assigned
Labels
PTAL Ready for peer review T-optimization Making things faster/smaller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize inner-product prover by inlining adjustment scalars
3 participants
@cathieyun @hdevalence @oleganza