Merge main into circuit #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `read32` function extracts the first 32 bytes of a slice as an array. This makes the parsing code cleaner.
Canonical serialization format for RangeProof
Now that the IPP points are stored in compressed form, they have to be decompressed during verification.
cathieyun
approved these changes
Jul 12, 2018
|
Oh, okay, I was going to add that to this PR. I don't think it's super important, but it seems like when merging changes from |
|
ok that sounds good for future changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the changes to use compressed points in the rangeproofs and inner product proofs.
The current circuit proof code stores the points in the circuit proof in uncompressed format, which is now inconsistent with the range proof code. Maybe this PR should also change the circuit proofs to use compressed points?