Disentangle Pedersen generators from Bulletproofs generators #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like a toolchain bump is in order! I updated other PRs to use |
hdevalence
force-pushed
the
pedersen
branch
from
6f6593e
to
53b5266
Compare
|
I also had to amend the commit to change the benchmarks to match the new API, so it was probably broken in at least two ways |
cathieyun
approved these changes
Sep 18, 2018
|
|
||
| #[test] | ||
| fn test_delta() { | ||
| let mut rng = OsRng::new().unwrap(); | ||
| let mut rng = rand::thread_rng(); |
There was a problem hiding this comment.
what's the motivation for changing the source of randomness?
There was a problem hiding this comment.
There's no really good reason -- I removed the OsRng that was used in other parts of the test code while changing that code, then removed the use declaration that brought it into scope, then realized that the test_delta function was using it, and didn't want to re-add it, so I just made everything use thread_rng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161.