Curve v2 (on develop branch) #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it appears that this breaks yoloproofs unless we will also uprev rand_core used in merlin crate |
|
Hi, it looks like this might be a duplicate of #303 ? |
|
These changes are included in #303, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uprev curve25519-dalek to v2 and use matching rand and rand_core versions (matching current master)
We need this because we are using bulletproofs/develop branch (for no_std support) and we also need to uprev curve25519-dalek to v2 (because the old version has a build.rs and depends on byteorder, but we also have build-dependencies that turn on byteorder/std, breaking our no_std build)