Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curve25519_dalek::SubgroupPoint: missing traits #617

Open
survived opened this issue Jan 25, 2024 · 1 comment
Open

curve25519_dalek::SubgroupPoint: missing traits #617

survived opened this issue Jan 25, 2024 · 1 comment

Comments

@survived
Copy link

survived commented Jan 25, 2024 •
edited
Loading

curve25519_dalek::SubgroupPoint does not implement certain traits, although it only wraps curve25519_dalek::EdwardsPoint which does implement these traits:

  • Zeroize
  • ConstantTimeEq
  • ConditionallySelectable
  • TryFrom<EdwardsPoint>
@survived survived changed the title Missing implementation of Zeroize for curve25519_dalek::SubgroupPoint Missing traits implementations for curve25519_dalek::SubgroupPoint Jan 25, 2024
@survived survived changed the title Missing traits implementations for curve25519_dalek::SubgroupPoint curve25519_dalek::SubgroupPoint: missing traits Jan 25, 2024
@AaronFeickert
Copy link
Contributor

AaronFeickert commented Aug 2, 2024 •
edited
Loading

The ConstantTimeEq and ConditionallySelectable traits were implemented in #672.

The functionality to (attempt to) get a SubgroupPoint from an EdwardsPoint does already exist via into_subgroup, though not using a TryFrom.

It looks like Zeroize simply isn't implemented. I just opened #682 to do so.

@AaronFeickert AaronFeickert mentioned this issue Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@survived @AaronFeickert