Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl TryFrom<&[u8]> for all compressed point types. #296

Merged
merged 7 commits into from
Nov 26, 2019
Merged

Impl TryFrom<&[u8]> for all compressed point types. #296

merged 7 commits into from
Nov 26, 2019

Commits on Oct 28, 2019

  1. Impl TryFrom<&[u8]> for all compressed point types. 

    This reduces copy-pasta in downstream users to check the length of the
slice beforehand.
    @isislovecruft
    isislovecruft committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    a7f317a View commit details
    Browse the repository at this point in the history

  2. Fix typo in TryFrom docstring.

    @isislovecruft
    isislovecruft committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    db3d26f View commit details
    Browse the repository at this point in the history

  3. Implement TryFrom<&[u8]> and ValidityCheck for MontgomeryPoint.

    @isislovecruft
    isislovecruft committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    1fa0048 View commit details
    Browse the repository at this point in the history

  4. Add custom error types, currently only used in TryFrom impls.

    @isislovecruft
    isislovecruft committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    1d8b399 View commit details
    Browse the repository at this point in the history

  5. Remove optional failure dependency and impl std::error::Error.

    @isislovecruft
    isislovecruft committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    c212241 View commit details
    Browse the repository at this point in the history

  6. Change all from_slice() constructors to return Option<T>s. 

    We due this in lieu of implementing `TryFrom` to allow for API
consumers to use the `?` operator to convert potential `None`s into
their own `Result<T, CustomError>` types for better error handling
with less boilerplate.

Note that this is a breaking API change.
    @isislovecruft
    isislovecruft committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    9ae2e3b View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Merge branch 'develop' into feature/compressed-try-from

    @isislovecruft
    isislovecruft committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    d52ab8b View commit details
    Browse the repository at this point in the history