Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up backend features and vendor curve25519_dalek_derive #531

Merged
merged 53 commits into from
Jun 22, 2023
Merged

Clean up backend features and vendor curve25519_dalek_derive #531

merged 53 commits into from
Jun 22, 2023

Commits on Jun 12, 2023

  1. Vendor import unsafe_target_features as curve25519-dalek-derive 

    Co-authored-by: Jan Bujak <jan@parity.io>
    @pinkforest @koute
    pinkforest and koute committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    39c34cb View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Rename vendored unsafe_target_features to curve25519-dalek-derive

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    31511c2 View commit details
    Browse the repository at this point in the history

  2. Plumb curve25519_dalek to curve25519_dalek_derive

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4c65862 View commit details
    Browse the repository at this point in the history

  3. Adjust CI for simd feature-less

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    6c78bcb View commit details
    Browse the repository at this point in the history

  4. Remove feature gates from avx2/ifma

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    96107fc View commit details
    Browse the repository at this point in the history

  5. De-plub rest of the redundant featuresets

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    1aa5038 View commit details
    Browse the repository at this point in the history

  6. mod vector does not depend on nightly

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    90e92fd View commit details
    Browse the repository at this point in the history

  7. Found the missing zeroize feature gate

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8dd4800 View commit details
    Browse the repository at this point in the history

  8. Fix cfg relay via build.rs

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7b68f1e View commit details
    Browse the repository at this point in the history

  9. Add buildtime compile diagnostics about backend selection

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b530a2a View commit details
    Browse the repository at this point in the history

  10. simd override fix

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    6af3d03 View commit details
    Browse the repository at this point in the history

  11. fmt

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    9923241 View commit details
    Browse the repository at this point in the history

  12. Empty

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    1933ca9 View commit details
    Browse the repository at this point in the history

  13. Fix diagnostics typo

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ead53fb View commit details
    Browse the repository at this point in the history

  14. Move curve25519-dalek-derive to top level

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    47adb22 View commit details
    Browse the repository at this point in the history

  15. Remove .gitignore from curve25519-dalek-derive

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e367aaa View commit details
    Browse the repository at this point in the history

  16. Update .gitignore for subdirs

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    1ffbb71 View commit details
    Browse the repository at this point in the history

  17. Re-label CI desc for simd

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    20b9149 View commit details
    Browse the repository at this point in the history

  18. Separate fiat from test default and add serial override test

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ffdefaf View commit details
    Browse the repository at this point in the history

  19. Add build script tests

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    2b8f0ae View commit details
    Browse the repository at this point in the history

  20. Documentation changes

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    175bc67 View commit details
    Browse the repository at this point in the history

  21. Fix build test

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b4114cc View commit details
    Browse the repository at this point in the history

  22. Ensure no incremental compilation for build script tests

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    07d0755 View commit details
    Browse the repository at this point in the history

  23. Remove redundant LICENSE from derive crate

    @pinkforest
    pinkforest committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a3d3c65 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Clean up backend selection doc further

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    eeb4b6c View commit details
    Browse the repository at this point in the history

  2. Better table column format

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    ee82d44 View commit details
    Browse the repository at this point in the history

  3. Wording fix

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    1275f26 View commit details
    Browse the repository at this point in the history

  4. Relative and wording fix

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    4c9ef40 View commit details
    Browse the repository at this point in the history

  5. Relative links are mess

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    cf013ec View commit details
    Browse the repository at this point in the history

  6. Relative link mess

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    1c34768 View commit details
    Browse the repository at this point in the history

  7. Vector needs to be included for docsrs

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    cf9ba9e View commit details
    Browse the repository at this point in the history

  8. docsrs is assumed AVX2 capable so this is not needed. 

    Revert "Vector needs to be included for docsrs"

This reverts commit cf9ba9e.
    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    731ff48 View commit details
    Browse the repository at this point in the history

  9. Reduce confusing implementation detail from pub doc

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    c2f219c View commit details
    Browse the repository at this point in the history

  10. Target not platform

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    4fe1079 View commit details
    Browse the repository at this point in the history

  11. Reduce gates in enum and allow dead_code in it

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    35b3cef View commit details
    Browse the repository at this point in the history

  12. The enum needs to be gated for now. 

    Revert "Reduce gates in enum and allow dead_code in it"

This reverts commit 35b3cef.
    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    95dfca0 View commit details
    Browse the repository at this point in the history

  13. Default backend is serial not auto

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    dc507b7 View commit details
    Browse the repository at this point in the history

  14. Adjust build script tests to serial not auto default

    @pinkforest
    pinkforest committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    0bc5de2 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Fix simd default on backend

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    b11fa4d View commit details
    Browse the repository at this point in the history

  2. Fix wording about instruction sets

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    f41ab86 View commit details
    Browse the repository at this point in the history

  3. Disable simd related features unless simd was determined via build

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    edeb5c2 View commit details
    Browse the repository at this point in the history

  4. Play the fmt game

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    840f8e5 View commit details
    Browse the repository at this point in the history

  5. Simply backend gates via build

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    b87ad6b View commit details
    Browse the repository at this point in the history

  6. Revert "Simply backend gates via build" 

    This reverts commit b87ad6b.

When --cfg curve25519_dalek_backend="simd" is chosen it cannot be
overriden as "serial" in build.rs and will result in both selected
    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    2755aa3 View commit details
    Browse the repository at this point in the history

  7. Correct gating for feature enable

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    9c42cc9 View commit details
    Browse the repository at this point in the history

  8. Add note and test about the override warning when unsuccesfull

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    91d0d6d View commit details
    Browse the repository at this point in the history

  9. Reduce complexity in build gating via compile_error

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    1ac7b2c View commit details
    Browse the repository at this point in the history

  10. Doc typo

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    770a394 View commit details
    Browse the repository at this point in the history

  11. Cosmetic panic error message fix

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    2eb2b17 View commit details
    Browse the repository at this point in the history

  12. Play the fmt game again

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    8bf3439 View commit details
    Browse the repository at this point in the history

  13. Refer to issue/532 around intended compile_error

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    1671d80 View commit details
    Browse the repository at this point in the history

  14. Squash annoying typo

    @pinkforest
    pinkforest committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    1bcbda5 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Some README cleanup

    @rozbb
    rozbb committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    919c8b4 View commit details
    Browse the repository at this point in the history