Implement ff and group traits - Rebased
#562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are placed behind the new `ff` feature flag.
tarcieri
reviewed
Aug 15, 2023
pinkforest
commented
Aug 15, 2023
Co-authored-by: Tony Arcieri <bascule@gmail.com>
Co-authored-by: Tony Arcieri <bascule@gmail.com>
tarcieri
reviewed
Aug 15, 2023
tarcieri
reviewed
Aug 15, 2023
tarcieri
reviewed
Aug 15, 2023
Co-authored-by: Tony Arcieri <bascule@gmail.com>
tarcieri
reviewed
Aug 15, 2023
|
Should we shift the trait impls into separate file/s - these files are getting big as noted by @rozbb #473 (review) Also should we refer to the PrimeField#associatedconstant.S docs someway somewhere perhaps |
|
Just to get it landed I'd propose keeping it close to #473 to simplify review. Refactoring can happen in follow-up PRs. |
tarcieri
reviewed
Aug 15, 2023
Co-authored-by: Tony Arcieri <bascule@gmail.com>
tarcieri
approved these changes
Aug 18, 2023
|
Thank you @tarcieri! Been extremely busy lately (proposing thesis). Also idk who did it but the 2-stage decompression trick is really slick. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some quick git dark arts 🪄 to re-base #473 and resolve the merge conflicts
Couple of warnings needs to be still addressed