Avoid cargo test -p curve25519-dalek-derive failure on ARM #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if this seems like the right solution, or if you'd like me to rework it. |
|
Seems fine to me |
tarcieri
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a MacBook M1, I noticed
cargo testin the workspace root fails. It fails due to the references to#[target_feature(enable = "avx2")]in theREADME.mdforcurve25519-dalek-derive.This PR avoids the test failure by adding conditional compile statements on the usages of
target_feature.cfgstatements are added as hidden lines in the examples and so they will not appear incargo doc. Hidden lines will appear when looking at the README on GitHub.