Make rand_core optional
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkforest
commented
Jan 15, 2023
| @@ -60,6 +61,7 @@ batch = ["alloc", "merlin", "rand_core"] | |||
| legacy_compatibility = [] | |||
| pkcs8 = ["ed25519/pkcs8"] | |||
| pem = ["alloc", "ed25519/pem", "pkcs8"] | |||
| rand_core = ["dep:rand_core"] | |||
There was a problem hiding this comment.
It is best to keep iterating explicitly all the features in Cargo.toml as it's easier to understand for downstream
robjtede
reviewed
Jan 15, 2023
pinkforest
commented
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented here via DOC PR #241 :
I have further proposal how to re-organise the examples to clear out lib .rs but I'll do it in separate PR
Depends on to get rid ofrandhere onbatchfeature:verify_batchdeterministic #256 - This PR turned into fix-up PR as some aligned fixes were there already