Implement Hash trait for VerifyingKey #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
returntoreality
force-pushed
the
hash_trait
branch
from
45f846b
to
d55cc35
Compare
|
@rozbb I see you pushed some newer changes from the 2.0 release branch. I'll rebase it and run rustfmt again, so the pipeline is happy. |
returntoreality
force-pushed
the
hash_trait
branch
from
9007157
to
1a51989
Compare
rozbb
reviewed
Jan 17, 2023
| /// [here](https://hdevalence.ca/blog/2020-10-04-its-25519am). | ||
| /// | ||
| /// If you don't care and/or don't want to deal with this, just make sure to use the | ||
| /// [`VerifyingKey::verify_strict`] function. |
There was a problem hiding this comment.
Note: this sentence will not be true until #267 is addressed.
|
Looks great. Thank you for sticking with this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase and improvement of #176. Makes the
VeryfyingKeyhashable so it can be used as aHashMapkey.