Minifying angular-bootstrap-datetimepicker fails with gulp-uglify

[henrikthorin]

Since your last update where you have removed all semicolons in your code, our gulp-minify fails resulting in a corrupt minified js file.

Please advice us what do to.
We will revert to 1.0.1 until we have a working solution.

[rbengtsson]

We're having this issue as well!

[dalelotts]

Can you create a Reduced Test Case/example for this problem?

Perhaps a minimal gibhub project that shows the problem.

You MUST have a recreation or I cannot work on this issue.

[amunro]

Absolutely running into this issue.

[dalelotts]

Still checking on a solution...

[dalelotts]

When concatenating the files together, adding in a semicolon between the file solves the issue. I've manually tested this several different ways, using multiple semicolons and various combinations of \r, \n, and ; and it always works after minification.

gulp.task('minify', function () {
  var destination = path.join(__dirname, 'build', 'js')
  return gulp.src(paths.src)
    .pipe(concat('datetimepicker.all.min.js', {newLine: ';'}))
    .pipe(uglify())
    .pipe(gulp.dest(destination))
});

This is the line that solves the problem .pipe(concat('datetimepicker.all.js', {newLine: ';'}))

[dalelotts]

This also works - changing the order of the operations and uglify first, then concatenate will put each file on its own line separated by \n. I guess is just depends on which output you like.

gulp.task('minify', function () {
  var destination = path.join(__dirname, 'build', 'js')
  return gulp.src(paths.src)
    .pipe(uglify())
    .pipe(concat('datetimepicker.all.min.js'))
    .pipe(gulp.dest(destination))
});

[dalelotts]

I forgot one very important rule about ASI in JavaScript. Never start a line with (, [, or `

I'll release a fix shortly.

For the following releases (not this one!), I will update the tests so they also run against the minified code so I can be 100% sure the code will minifiy correctly before release.

[dalelotts]

Thanks for your patience and understanding @HONK82 , @rbengtsson , @amunro, and everyone else.

I should know better! 💯% of the time when I think the problem is not in my code...the problem is in my code! 😞

[amunro]

Appreciate the updates! If I had $1 for every bug i created.... I'm just glad it wasn't me this time :)

[henrikthorin]

Thank you for fixing this issue.

[dalelotts]

@HONK82 Thanks for reporting it!

[calopez]

This fix is not included in the last version(1.1.3) of the library.

I guess just missing a new tag 1.1.4 for the current master

[dalelotts]

@calopez I just downloaded the source - if this is not working for you then you likely have a defect in your build process.

See #347 for options to fix your build process.