New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
### Restrict past dates and times from date time now #389
Conversation
Thanks for the PR! Can you help me understand the use case? Why is so much code necessary? |
@dalelotts, I wanted to make it possible to disable all of today's times prior to now (I may add on offset) so that when the users of my app are selecting a call back time, there is no chance of them selecting past times. At first I thought it would be a case of removing the midnight setter, however this then disabled the selection of the date. I managed to stop that bug only for 2 more to spawn from that. Then I kept finding bug after bug until the solution grew into this, a cleaner solution is more than welcome. |
Why doesn't accepting |
@dalelotts i haven't tried that, i'll look into it on Monday, i'll let you know how it goes. Thanks |
@dalelotts Cheers, using the view parameter works great |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature with doc update
What is the current behavior? (You can also link to an open issue here)
Does not disable the past times within the current day
What is the new behavior (if this is a feature change)?
Disables the past times within the current day
Does this PR introduce a breaking change?
No, its just a useful feature to filter
Please check if the PR fulfills these requirements
develop
branch. (Please do not submit PR's to the master branch)Other information: